Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support helm in freightline #1730

Merged
merged 1 commit into from
Apr 2, 2024
Merged

fix: support helm in freightline #1730

merged 1 commit into from
Apr 2, 2024

Conversation

rbreeze
Copy link
Contributor

@rbreeze rbreeze commented Apr 2, 2024

Fixes #1280

CleanShot 2024-04-02 at 11 18 27@2x

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from a team as a code owner April 2, 2024 18:19
Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 6510ed1
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/660c4c4e9e436d0008183162
😎 Deploy Preview https://deploy-preview-1730.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.13%. Comparing base (d079608) to head (6510ed1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1730   +/-   ##
=======================================
  Coverage   44.13%   44.13%           
=======================================
  Files         207      207           
  Lines       13105    13105           
=======================================
  Hits         5784     5784           
  Misses       7078     7078           
  Partials      243      243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour
Copy link
Member

krancour commented Apr 2, 2024

@rbreeze this is non-blocking, but would the Helm logo be a more intuitive thing to use here than the anchor? Or are we already using the anchor to represent Helm charts in other places?

@rbreeze
Copy link
Contributor Author

rbreeze commented Apr 2, 2024

In an ideal world I'd also prefer the "real" Helm logo, but unfortunately FontAwesome doesn't have a built-in icon for Helm... eventually we could consider adding a custom PNG (and same thing for the Argo logo), but for now I figured it's more trouble than it's worth. I've been using the anchor icon in other PRs to represent Helm up to this point too

@rbreeze rbreeze added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit cddd2bb Apr 2, 2024
20 checks passed
@rbreeze rbreeze deleted the freightline-helm branch April 2, 2024 19:17
@krancour
Copy link
Member

krancour commented Apr 2, 2024

but for now I figured it's more trouble than it's worth

Totally fine with that. And even with it being an anchor instead of the Helm logo, this is a major improvement. Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warehouse helm subscription is not working
3 participants