Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: surface warehouse reconciliation errors in DAG #1736

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

rbreeze
Copy link
Contributor

@rbreeze rbreeze commented Apr 2, 2024

Fixes #1448

Errors UI:

CleanShot 2024-04-02 at 13 30 51@2x
CleanShot 2024-04-02 at 13 31 06@2x

A couple of other small enhancements:
CleanShot 2024-04-02 at 13 31 39@2x
CleanShot 2024-04-02 at 13 31 30@2x

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from a team as a code owner April 2, 2024 20:35
Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit e0adb98
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/660c6bfba1801300081551a9
😎 Deploy Preview https://deploy-preview-1736.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rbreeze rbreeze requested a review from krancour April 2, 2024 20:36
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.13%. Comparing base (0e8f38e) to head (e0adb98).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1736   +/-   ##
=======================================
  Coverage   44.13%   44.13%           
=======================================
  Files         207      207           
  Lines       13105    13105           
=======================================
  Hits         5784     5784           
  Misses       7078     7078           
  Partials      243      243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbreeze rbreeze added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit 274767d Apr 2, 2024
16 checks passed
@rbreeze rbreeze deleted the warehouse-error-ui branch April 2, 2024 23:16
@krancour krancour added this to the v0.5.0 milestone Apr 2, 2024
krancour pushed a commit to krancour/kargo that referenced this pull request Apr 2, 2024
Signed-off-by: Remington Breeze <remington@breeze.software>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: surface warehouse reconciliation errors
3 participants