Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a couple of conveniences for easily running Kargo API locally #1738

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

rbreeze
Copy link
Contributor

@rbreeze rbreeze commented Apr 2, 2024

Related to #1205

Run . ./hack/import-env.sh to import environment variables from .env.dev to your local shell

Run make start-api-local to start the API locally

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from a team as a code owner April 2, 2024 20:57
@rbreeze rbreeze requested a review from krancour April 2, 2024 20:57
Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 746361c
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/660ddd0670486d0008d99f83
😎 Deploy Preview https://deploy-preview-1738.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.13%. Comparing base (fbddc83) to head (746361c).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1738   +/-   ##
=======================================
  Coverage   44.13%   44.13%           
=======================================
  Files         207      207           
  Lines       13105    13105           
=======================================
  Hits         5784     5784           
  Misses       7078     7078           
  Partials      243      243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbreeze rbreeze requested a review from jessesuen April 2, 2024 23:33
Signed-off-by: Remington Breeze <remington@breeze.software>
Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the .env.dev useful outside of start-api-local? If not, WDYT about creating a ./hack/start-api-local.sh which has all the envs in the same file (can be overridden from environment).

Then the Makefile target just runs that?

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze enabled auto-merge April 3, 2024 22:43
hack/start-api.sh Outdated Show resolved Hide resolved
Co-authored-by: Jesse Suen <jessesuen@users.noreply.github.com>
@rbreeze rbreeze added this pull request to the merge queue Apr 3, 2024
Merged via the queue into main with commit 0ffec15 Apr 3, 2024
16 checks passed
@rbreeze rbreeze deleted the local-api branch April 3, 2024 22:59
@krancour krancour added this to the v0.6.0 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants