Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor kargo events #1853

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Conversation

gdsoumya
Copy link
Contributor

This PR :

  1. Fixes small bit of promotion reconciler cleanup #1851
  2. Adds freight creation time to all promotion/freight events

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
@gdsoumya gdsoumya requested a review from a team as a code owner April 16, 2024 16:23
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit d38508e
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/661eb49a336850000808a17f
😎 Deploy Preview https://deploy-preview-1853.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 38.88889% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 46.14%. Comparing base (5287d0e) to head (d38508e).

Files Patch % Lines
internal/controller/promotions/promotions.go 9.09% 9 Missing and 1 partial ⚠️
api/v1alpha1/event.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1853      +/-   ##
==========================================
+ Coverage   46.11%   46.14%   +0.03%     
==========================================
  Files         213      213              
  Lines       13873    13865       -8     
==========================================
+ Hits         6397     6398       +1     
+ Misses       7191     7183       -8     
+ Partials      285      284       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdsoumya gdsoumya requested a review from devholic April 16, 2024 17:39
@gdsoumya gdsoumya added this pull request to the merge queue Apr 16, 2024
Merged via the queue into akuity:main with commit d3276a0 Apr 16, 2024
15 of 16 checks passed
@gdsoumya gdsoumya deleted the feat/refactor_events branch April 16, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

small bit of promotion reconciler cleanup
3 participants