Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): Added annotation: to api.service and default api.service.annotations value to values.yaml #1877

Merged
merged 5 commits into from
Apr 20, 2024

Conversation

ed-boykin
Copy link
Contributor

Added a section to charts/kargo/templates/api/service.yaml to add 0 to many annotations to the api service.
When hosting Kargo in a managed K8s system, in this case AKS, an annotation can be added to create an internal or externally facing managed azure load balancer for ingress.

…value to values.yaml

Signed-off-by: Edward Boykin <ed.boykin@corecard.com>
@ed-boykin ed-boykin requested a review from a team as a code owner April 19, 2024 17:41
Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for docs-kargo-akuity-io canceled.

Name Link
🔨 Latest commit c3b2b31
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66231417a513a30007f88be5

@ed-boykin ed-boykin changed the title Added annotation: to api.service and default api.service.annotations value to values.yaml feat(chart): Added annotation: to api.service and default api.service.annotations value to values.yaml Apr 19, 2024
@krancour
Copy link
Member

krancour commented Apr 19, 2024

Hi @ed-boykin. Thanks for this!

I understand your need, but want to suggest a more general-purpose approach to this so that arbitrary annotations can be added to any/all Kargo pods, as there may be reasons beyond those you are encountering to do such a thing.

If I may suggest, @MPritsch has taken a very nice approach to doing something similar for adding arbitrary env vars to any/all Kargo pods over in #1874.

If you could emulate that approach, I think this would be something we could get into v0.6.0.

My apologies! I just realized this is for services and not for pods. I will continue reviewing this.

Thanks again!

charts/kargo/values.yaml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.38%. Comparing base (fe958c8) to head (48d72fb).

❗ Current head 48d72fb differs from pull request most recent head c3b2b31. Consider uploading reports for the commit c3b2b31 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1877   +/-   ##
=======================================
  Coverage   46.38%   46.38%           
=======================================
  Files         215      215           
  Lines       14066    14066           
=======================================
  Hits         6524     6524           
  Misses       7243     7243           
  Partials      299      299           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ed-boykin and others added 3 commits April 19, 2024 16:01
Signed-off-by: Edward Boykin <ed.boykin@corecard.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour krancour merged commit 9d358f4 into akuity:main Apr 20, 2024
11 of 12 checks passed
@krancour
Copy link
Member

Thank you @ed-boykin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants