-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): Added annotation: to api.service and default api.service.annotations value to values.yaml #1877
Conversation
…value to values.yaml Signed-off-by: Edward Boykin <ed.boykin@corecard.com>
✅ Deploy Preview for docs-kargo-akuity-io canceled.
|
Hi @ed-boykin. Thanks for this!
My apologies! I just realized this is for services and not for pods. I will continue reviewing this. Thanks again! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1877 +/- ##
=======================================
Coverage 46.38% 46.38%
=======================================
Files 215 215
Lines 14066 14066
=======================================
Hits 6524 6524
Misses 7243 7243
Partials 299 299 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Edward Boykin <ed.boykin@corecard.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Thank you @ed-boykin! |
Added a section to charts/kargo/templates/api/service.yaml to add 0 to many annotations to the api service.
When hosting Kargo in a managed K8s system, in this case AKS, an annotation can be added to create an internal or externally facing managed azure load balancer for ingress.