-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): allow ui refresh to deep links #1878
Conversation
Signed-off-by: Zhenya Khvan <zhenya.khvan@gmail.com>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Nice find. I'll review shortly! |
A note about how this escaped my attention... When we run Kargo from source with The embedded-ness of the UI was tested by running the So... being unable to progress past the login page, I never actually did see anything deeper than the login page served from the embedded FS. Especially since assets loaded, it didn't occur to me that anything was amiss. Installing the unstable chart does indeed permit me to easily reproduce the problem. |
@zkhvan I proposed minor tweaks for readability and if they're cool with you then this PR lgtm. |
Co-authored-by: Kent Rancourt <kent.rancourt@gmail.com> Signed-off-by: Zhenya Khvan <zhenya.khvan@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1878 +/- ##
==========================================
- Coverage 46.38% 46.26% -0.12%
==========================================
Files 215 215
Lines 14066 14101 +35
==========================================
Hits 6524 6524
- Misses 7243 7278 +35
Partials 299 299 ☔ View full report in Codecov by Sentry. |
After #1833, installing the chart into a cluster will cause links to nested paths to return 404.
Reproduction
0.6.0-unstable-20240419
404 page not found
Since assets are served through the API server, the router needs to redirect the URLs to
index.html
since the UI is a single page application.@krancour I figured you'd have context on this, so tagging you. I'm not sure if this is something you've encountered and were thinking of an alternative solution.