Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(controller): extend unit tests for path filtering of Warehouse Git subscription #1879

Merged
merged 1 commit into from
Apr 22, 2024
Merged

chore(controller): extend unit tests for path filtering of Warehouse Git subscription #1879

merged 1 commit into from
Apr 22, 2024

Conversation

maksimstankevic
Copy link
Contributor

@maksimstankevic maksimstankevic commented Apr 20, 2024 •
edited by hiddeco
Loading

Fixes #1862

@maksimstankevic
more unit tests for includePaths/excludePaths
da73c65 
Signed-off-by: Maksim Stankevic <maksim.stankevic1@gmail.com>
@maksimstankevic maksimstankevic requested a review from a team as a code owner April 20, 2024 07:34
@netlify Netlify
Copy link

netlify bot commented Apr 20, 2024 •
edited
Loading

✅ Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit da73c65
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/6623701a9a01d60008694c72
😎 Deploy Preview https://deploy-preview-1879.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Apr 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.26%. Comparing base (83a3b3c) to head (da73c65).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1879      +/-   ##
==========================================
- Coverage   46.42%   46.26%   -0.16%     
==========================================
  Files         215      215              
  Lines       14039    14101      +62     
==========================================
+ Hits         6517     6524       +7     
- Misses       7228     7278      +50     
- Partials      294      299       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiddeco hiddeco added this to the v0.6.0 milestone Apr 22, 2024
@hiddeco hiddeco changed the title feat(controller): more unit tests for includePaths/excludePaths in Warehouse Git subscription chore(controller): extend unit tests for path filtering of Warehouse Git subscription Apr 22, 2024
@krancour krancour added this pull request to the merge queue Apr 22, 2024
Merged via the queue into akuity:main with commit 5d53351 Apr 22, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
area/controller kind/chore priority/normal
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

Add more tests for includePaths/excludePaths filters in Warehouse Git subscription
3 participants
@maksimstankevic @hiddeco @krancour