-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): use Unstructured to return raw response #1903
Conversation
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1903 +/- ##
==========================================
+ Coverage 46.74% 46.84% +0.09%
==========================================
Files 220 220
Lines 14411 14464 +53
==========================================
+ Hits 6737 6776 +39
- Misses 7374 7382 +8
- Partials 300 306 +6 ☔ View full report in Codecov by Sentry. |
02444a0
to
20214fc
Compare
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
20214fc
to
418bf14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange that this technique is necessary. Do you know why Kubernetes API doesn't suffer the same problem given that the authentication
field is not a pointer?
@jessesuen I searched hard and looked at the Kubernetes SIG YAML library and the serializers in API machinery but could not figure out what causes the API to drop the empty objects. If I happen to run into the answer, I will revise what I introduced here. |
Fixes: #1899
This pull request ensures that the raw object data returned by the Kargo API matches the data from the Kubernetes API server. Which, unlike the JSON and YAML serializers, purges empty structures.