Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(controller): Apply Warehouse Git subscription path filters to all CommitSelectionStrategy types #1918

Merged
merged 5 commits into from
May 2, 2024
Merged

feat(controller): Apply Warehouse Git subscription path filters to all CommitSelectionStrategy types #1918

merged 5 commits into from
May 2, 2024

Conversation

maksimstankevic
Copy link
Contributor

@maksimstankevic maksimstankevic commented May 1, 2024 •
edited by krancour
Loading

Fixes #1896

@maksimstankevic
Apply Warehouse Git subscription path filters to all CommitSelectionS…
03cf0d5 
…trategy types

Signed-off-by: Maksim Stankevic <maksim.stankevic1@gmail.com>
@maksimstankevic maksimstankevic requested a review from a team as a code owner May 1, 2024 09:02
@netlify Netlify
Copy link

netlify bot commented May 1, 2024 •
edited
Loading

✅ Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 4d8e20c
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/6633961390d4f700084e984e
😎 Deploy Preview https://deploy-preview-1918.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented May 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.28571% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 45.68%. Comparing base (14522e0) to head (fbea61f).
Report is 16 commits behind head on main.

❗ Current head fbea61f differs from pull request most recent head 4d8e20c. Consider uploading reports for the commit 4d8e20c to get more accurate results

Files Patch % Lines
internal/controller/warehouses/git.go 94.28% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1918      +/-   ##
==========================================
- Coverage   46.74%   45.68%   -1.07%     
==========================================
  Files         220      235      +15     
  Lines       14411    15827    +1416     
==========================================
+ Hits         6737     7230     +493     
- Misses       7374     8241     +867     
- Partials      300      356      +56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maksimstankevic maksimstankevic mentioned this pull request May 1, 2024
Closed
@maksimstankevic
more testing
2cfd0c5 
Signed-off-by: Maksim Stankevic <maksim.stankevic1@gmail.com>
@krancour krancour changed the title feat(controller): Apply Warehouse Git subscription path filters to all CommitSelectionS… feat(controller): Apply Warehouse Git subscription path filters to all CommitSelectionStrategy types May 1, 2024
@maksimstankevic
Revert "Apply Warehouse Git subscription path filters to all CommitSe…
2d617d2 
…lectionStrategy types"

This reverts commit 03cf0d5.

Signed-off-by: Maksim Stankevic <maksim.stankevic1@gmail.com>
@maksimstankevic
refactor for better code readability
fbea61f 
Signed-off-by: Maksim Stankevic <maksim.stankevic1@gmail.com>
@krancour
Copy link
Member

krancour commented May 1, 2024 •
edited
Loading

@maksimstankevic this looks great. Only nit is that this comment might not be relevant anymore since there's no longer an early return for this selection strategy.

https://github.com/akuity/kargo/blob/fbea61f1384cc226922f2b6657f0fa27bd1fbdf2/internal/controller/warehouses/git.go#L175C3-L177C13

@maksimstankevic
remove old comment
4d8e20c 
Signed-off-by: Maksim Stankevic <maksim.stankevic1@gmail.com>
@maksimstankevic
Copy link
Contributor Author

@maksimstankevic this looks great. Only nit is that this comment might not be relevant anymore since there's no longer an early return for this selection strategy.

https://github.com/akuity/kargo/blob/fbea61f1384cc226922f2b6657f0fa27bd1fbdf2/internal/controller/warehouses/git.go#L175C3-L177C13

removed

@krancour krancour added this to the v0.7.0 milestone May 2, 2024
krancour
krancour approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@krancour krancour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thank you @maksimstankevic !

@krancour krancour added this pull request to the merge queue May 2, 2024
Merged via the queue into akuity:main with commit e90b388 May 2, 2024
14 checks passed
@krancour krancour mentioned this pull request May 2, 2024
Closed
11 tasks
krancour pushed a commit to krancour/kargo that referenced this pull request May 4, 2024
@maksimstankevic @krancour
feat(controller): Apply Warehouse Git subscription path filters to al…
9f8ec81 
…l CommitSelectionStrategy types (akuity#1918)

Signed-off-by: Maksim Stankevic <maksim.stankevic1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krancour krancour krancour approved these changes

Assignees

@krancour krancour

@maksimstankevic maksimstankevic

Labels
area/controller kind/enhancement priority/normal
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

Apply Warehouse Git subscription path filters to all CommitSelectionStrategy types
2 participants
@maksimstankevic @krancour