Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(promotions): only check revision match sync result if found #1923

Merged
merged 1 commit into from
May 1, 2024

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented May 1, 2024

Fixes: #1922

Copy link

netlify bot commented May 1, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 33aff28
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/6632a42de552db000898ddf8
😎 Deploy Preview https://deploy-preview-1923.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco force-pushed the fix-health-check branch from ebdae78 to 33aff28 Compare May 1, 2024 20:20
@krancour krancour added this to the v0.6.0 milestone May 1, 2024
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.67%. Comparing base (af4feb5) to head (33aff28).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1923      +/-   ##
==========================================
+ Coverage   45.58%   45.67%   +0.08%     
==========================================
  Files         235      235              
  Lines       15793    15824      +31     
==========================================
+ Hits         7199     7227      +28     
- Misses       8240     8241       +1     
- Partials      354      356       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiddeco hiddeco changed the title fix(promotions): check only revision match during health check if found fix(promotions): only check revision match sync result if found May 1, 2024
@hiddeco hiddeco enabled auto-merge May 1, 2024 20:26
@hiddeco hiddeco added this pull request to the merge queue May 1, 2024
Merged via the queue into akuity:main with commit 7940c70 May 1, 2024
17 checks passed
@hiddeco hiddeco deleted the fix-health-check branch May 1, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug in health check making promotions fail
2 participants