Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Permissions Management #1939

Merged
merged 12 commits into from
May 3, 2024
Merged

feat(ui): Permissions Management #1939

merged 12 commits into from
May 3, 2024

Conversation

rbreeze
Copy link
Contributor

@rbreeze rbreeze commented May 2, 2024

Fixes #1920

CleanShot 2024-05-02 at 15 06 36@2x
CleanShot 2024-05-02 at 15 08 43@2x
CleanShot 2024-05-02 at 15 07 04@2x
CleanShot 2024-05-02 at 15 03 52@2x
CleanShot 2024-05-02 at 15 04 05@2x
CleanShot 2024-05-02 at 15 06 48@2x
CleanShot 2024-05-02 at 15 10 11@2x

rbreeze added 3 commits May 2, 2024 14:28
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from a team as a code owner May 2, 2024 22:01
Copy link

netlify bot commented May 2, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 9cce92f
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66356bc2c81c010008248f81
😎 Deploy Preview https://deploy-preview-1939.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.25%. Comparing base (2a26e2a) to head (9cce92f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1939   +/-   ##
=======================================
  Coverage   46.25%   46.25%           
=======================================
  Files         235      235           
  Lines       16004    16004           
=======================================
  Hits         7402     7402           
  Misses       8242     8242           
  Partials      360      360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze added this to the v0.6.0 milestone May 2, 2024
@jessesuen
Copy link
Member

jessesuen commented May 2, 2024

I didn't think about how an RBAC UI might might look like until now, but now that I've seen it. I have suggestions on ways to simplify the UX.

Here are things I'd like to simplify:

  1. This UI supports arbitrary K8s resources with text fields for apiVersion/group/kind. I'm proposing to limit this to Kargo-specific GVKs so that users don't have to type groups, apiVersions, resources, etc... Also, there's no reason we need to support other things like deployments/pods/etc... In other words, when adding a rule, they would only be able to select from: Stages, Promotions, Warehouses, Secrets, AnalysisTemplates, and we would format this with the proper GVK in the rule before submitting to API.

  2. Similar to 1, verbs are well known: create, update, delete, patch, list, promote (promote only applies to stages). Instead of a text field, a checkbox of predefined verbs would be helpful.

  3. The emails/sub/groups can be under a subtitle called "OIDC bindings". Instead of subs, let's call it Subjects.

  4. Though a form is nice, I still think a YAML editor would be desired.

Let me know if any of this is feasible in short timeframe of v0.6. Otherwise, I'm willing for this to be done as a follow-up in v0.7

@rbreeze
Copy link
Contributor Author

rbreeze commented May 3, 2024

Updated interface:

CleanShot 2024-05-02 at 21 59 11@2x

CleanShot 2024-05-02 at 22 01 29@2x

Signed-off-by: Remington Breeze <remington@breeze.software>
rbreeze added 2 commits May 3, 2024 11:01
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from jessesuen May 3, 2024 19:43
rbreeze added 5 commits May 3, 2024 15:35
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested review from krancour and jessesuen May 3, 2024 23:36
@rbreeze rbreeze enabled auto-merge May 3, 2024 23:39
Copy link
Member

@krancour krancour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@rbreeze rbreeze added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit d949b08 May 3, 2024
16 checks passed
@rbreeze rbreeze deleted the permissions-ui branch May 3, 2024 23:48
krancour pushed a commit to krancour/kargo that referenced this pull request May 4, 2024
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze added the area/ui label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: project-level user / role management
3 participants