fix(chart): update and clean up global admin and viewer roles #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kargo-akuity-io canceled.
|
11 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1944 +/- ##
=======================================
Coverage 45.68% 45.68%
=======================================
Files 235 235
Lines 15831 15831
=======================================
Hits 7232 7232
Misses 8242 8242
Partials 357 357 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
krancour
force-pushed
the
krancour/chart-fixes
branch
from
4c01cf3 to
ed698cf
Compare
krancour
changed the title
hiddeco
approved these changes
May 3, 2024
krancour
added a commit
to krancour/kargo
that referenced
this pull request
May 4, 2024
…#1944) Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some missing permissions. I also cleaned things up a bit and documented them better with comments.