feat: use config value if no address passed to login command #1975
Conversation
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| cmd := &cobra.Command{ | ||
| Use: "login SERVER_ADDRESS (--admin | --kubeconfig | --sso)", | ||
| Args: option.ExactArgs(1), | ||
| Use: "login [SERVER_ADDRESS] (--admin | --kubeconfig | --sso)", |
There was a problem hiding this comment.
Would it better to show config address like below?
| Use: "login [SERVER_ADDRESS] (--admin | --kubeconfig | --sso)", | |
| Use: "login [SERVER_ADDRESS | <default address here>] (--admin | --kubeconfig | --sso)", |
There was a problem hiding this comment.
The current is fine, as the default address is not actually being used as an argument but as a fallback.
Instead, it may be better to instruct people how to make use of the default address in the Example section.
There was a problem hiding this comment.
Added an example for omitted server address: c327f72
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1975 +/- ##
==========================================
- Coverage 46.25% 46.21% -0.04%
==========================================
Files 235 235
Lines 16005 16017 +12
==========================================
Hits 7403 7403
- Misses 8242 8254 +12
Partials 360 360 ☔ View full report in Codecov by Sentry. |
#1975 (comment) Signed-off-by: Sunghoon Kang <hoon@akuity.io>
Fixes #1974 This commit uses the address in config if no address is passed to the login command. Signed-off-by: Sunghoon Kang <hoon@akuity.io>
#1975 (comment) Signed-off-by: Sunghoon Kang <hoon@akuity.io>
Co-authored-by: Hidde Beydals <hiddeco@users.noreply.github.com>
Fixes #1974
This commit uses the address in config if no address is passed to the login command.