Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): populate warehouse field in new freight #2026

Merged
merged 1 commit into from
May 16, 2024

Conversation

krancour
Copy link
Member

Follow up to #1984.

Freight have always been indexed by the Warehouse that created them. This is important in determining a piece of Freight's eligibility for promotion to an Stage that's subscribed directly to a Warehouse wherein all Freight from that Warehouse are implicitly qualified.

#1984 mistakenly did not set the Warehouse field on new Freight, which broke that index and, by extension, has made new Freight unavailable for promotion to "zero Stages."

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour krancour added this to the v0.7.0 milestone May 16, 2024
@krancour krancour requested a review from hiddeco May 16, 2024 18:25
@krancour krancour self-assigned this May 16, 2024
@krancour krancour requested a review from a team as a code owner May 16, 2024 18:25
Copy link

netlify bot commented May 16, 2024

Deploy Preview for docs-kargo-akuity-io canceled.

Name Link
🔨 Latest commit 422022c
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66464f9dc29cee0008e67ee9

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.81%. Comparing base (94f8d43) to head (422022c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2026   +/-   ##
=======================================
  Coverage   45.80%   45.81%           
=======================================
  Files         235      235           
  Lines       16191    16192    +1     
=======================================
+ Hits         7417     7418    +1     
  Misses       8413     8413           
  Partials      361      361           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this pull request to the merge queue May 16, 2024
Merged via the queue into akuity:main with commit 828acc0 May 16, 2024
24 checks passed
@krancour krancour deleted the krancour/warehouse-fix branch May 16, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants