Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(warehouse): enrich discovery logs #2035

Merged
merged 3 commits into from
May 21, 2024

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented May 17, 2024

Related to #1984

This brings the logging for Git and Helm artifact discovery up to the same level as what was already done for container images. Providing much richer data on trace level, and more structured information at the debug level.

Copy link

netlify bot commented May 17, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 8f4705f
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/664cf039e942d000077699b6
😎 Deploy Preview https://deploy-preview-2035.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hiddeco hiddeco force-pushed the warehouse-discovery-logs branch 2 times, most recently from 6d870a7 to f5f7122 Compare May 17, 2024 14:13
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 45.68%. Comparing base (473eacd) to head (601e830).

Current head 601e830 differs from pull request most recent head 8f4705f

Please upload reports for the commit 8f4705f to get more accurate results.

Files Patch % Lines
internal/controller/warehouses/git.go 73.33% 6 Missing and 2 partials ⚠️
internal/image/newest_build_selector.go 0.00% 5 Missing ⚠️
internal/controller/warehouses/images.go 75.00% 4 Missing ⚠️
internal/controller/warehouses/helm.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2035      +/-   ##
==========================================
- Coverage   45.79%   45.68%   -0.12%     
==========================================
  Files         236      234       -2     
  Lines       16077    16042      -35     
==========================================
- Hits         7362     7328      -34     
+ Misses       8355     8354       -1     
  Partials      360      360              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiddeco hiddeco force-pushed the warehouse-discovery-logs branch from f5f7122 to 601e830 Compare May 17, 2024 14:30
Copy link
Member

@krancour krancour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after conflicts are resolved

hiddeco added 3 commits May 21, 2024 21:04
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco force-pushed the warehouse-discovery-logs branch from 601e830 to 8f4705f Compare May 21, 2024 19:04
@hiddeco hiddeco enabled auto-merge May 21, 2024 19:08
@hiddeco hiddeco added this pull request to the merge queue May 21, 2024
Merged via the queue into akuity:main with commit 8ca680f May 21, 2024
15 checks passed
@hiddeco hiddeco deleted the warehouse-discovery-logs branch May 21, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants