feat(warehouse): allow discovery interval and limit configurations

[hiddeco]

This pull request adds the following things (as documented in the follow-up section of #1984):

1. The option to define a custom interval at which the Warehouse attempts to discover new artifacts (instead of the 5m0s default).

   spec:
     interval: 1h0m

2. The option (for each subscription) to limit artifacts (instead of the default of 20), with an upper limit of 100.

   spec:
     subscriptions:
     - git:
         discoveryLimit: 5
     - chart:
         discoveryLimit: 100
     - image:
         discoveryLimit: 25

[netlify]

✅ Deploy Preview for docs-kargo-akuity-io ready!

Name	Link
🔨 Latest commit	7548a95
🔍 Latest deploy log	https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/664c4a551ea50c000857187f
😎 Deploy Preview	https://deploy-preview-2038.kargo.akuity.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[hiddeco]

This is a common workaround for the issue described here: kubernetes/apiextensions-apiserver#56

I took the further liberty to drop ms from the regex, as we probably do not want people to go below the seconds (and the level of precision in combination with e.g. minutes has little value).

[codecov]

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 45.63%. Comparing base (881c012) to head (7548a95).
Report is 2 commits behind head on main.

Files	Patch %	Lines
internal/controller/warehouses/images.go	0.00%	1 Missing ⚠️
internal/controller/warehouses/warehouses.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2038   +/-   ##
=======================================
  Coverage   45.62%   45.63%           
=======================================
  Files         234      234           
  Lines       15998    16002    +4     
=======================================
+ Hits         7299     7302    +3     
- Misses       8342     8344    +2     
+ Partials      357      356    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[krancour]

We are nice people

😂 ❤️

[krancour]

Nice and clean.

[hiddeco]

@krancour when I woke up on Saturday I actually had a small improvement in mind, might be worth thinking about this so I can potentially implement it tomorrow.

Besides the discoveryLimit on subscription items, it could be an idea to also have an object global fallback default:

discovery:
  limit: 30
subscriptions:
- discoveryLimit: 100 # overwrite

Which could then also possibly result in:

discovery:
  interval: 1h0s # now nested