Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart): dex additional volumes indentation #2072

Merged
merged 1 commit into from
May 30, 2024

Conversation

wmiller112
Copy link
Contributor

@wmiller112 wmiller112 commented May 29, 2024

Chart render fails with additional dex volumes added, using example in values.yaml results in error due to volume formatting.

    volumes:
      - name: config
        projected:
          sources:
          - secret:
              name: kargo-dex-server-cert
              items:
              - key: tls.crt
                path: tls.crt
              - key: tls.key
                path: tls.key
          - secret:
              name: kargo-dex-server
              items:
              - key: config.yaml
                path: config.yaml
        - name: google-json
          secret:
            defaultMode: 420
            secretName: kargo-google-groups-json

@wmiller112 wmiller112 requested a review from a team as a code owner May 29, 2024 19:15
Copy link

netlify bot commented May 29, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 08f4bf3
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/665780465beec70008077744
😎 Deploy Preview https://deploy-preview-2072.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: William <will.miller@loom.com>
@wmiller112 wmiller112 force-pushed the dex-deployment-indentation branch from a502674 to 08f4bf3 Compare May 29, 2024 19:21
@krancour
Copy link
Member

Thank you @wmiller112!

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.86%. Comparing base (2364ae6) to head (08f4bf3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2072   +/-   ##
=======================================
  Coverage   45.86%   45.86%           
=======================================
  Files         237      237           
  Lines       16197    16197           
=======================================
  Hits         7428     7428           
  Misses       8406     8406           
  Partials      363      363           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this pull request to the merge queue May 30, 2024
Merged via the queue into akuity:main with commit 21c8b1f May 30, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants