-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: transition to logr (with an ergonomic wrapper) #2073
Conversation
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2073 +/- ##
==========================================
- Coverage 45.79% 45.69% -0.10%
==========================================
Files 238 237 -1
Lines 16278 16401 +123
==========================================
+ Hits 7455 7495 +40
- Misses 8455 8540 +85
+ Partials 368 366 -2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
8a25f1a
to
2110feb
Compare
Fixes #1419
Supersedes #1791
This PR transitions us from using logrus directly throughout our code base to using a new, ergonomic wrapper around logr, with logrus still used, for now, as the underlying implementation.
If we want to transition off of logrus (since it is unsupported), this PR should leave us in a good position to accomplish that relatively easily in a follow-up.