Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: transition to logr (with an ergonomic wrapper) #2073

Merged
merged 2 commits into from
May 31, 2024

Conversation

krancour
Copy link
Member

Fixes #1419

Supersedes #1791

This PR transitions us from using logrus directly throughout our code base to using a new, ergonomic wrapper around logr, with logrus still used, for now, as the underlying implementation.

If we want to transition off of logrus (since it is unsupported), this PR should leave us in a good position to accomplish that relatively easily in a follow-up.

Copy link

netlify bot commented May 30, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 2110feb
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/6658d2cee1046f00086e21d2
😎 Deploy Preview https://deploy-preview-2073.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@krancour krancour changed the title Krancour/logging refactor: transition to logr (with an ergonomic wrapper) May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 42.41935% with 357 lines in your changes are missing coverage. Please review.

Project coverage is 45.69%. Comparing base (2d4aaf5) to head (8a25f1a).

Current head 8a25f1a differs from pull request most recent head 2110feb

Please upload reports for the commit 2110feb to get more accurate results.

Files Patch % Lines
internal/controller/stages/watches.go 0.00% 83 Missing ⚠️
internal/image/newest_build_selector.go 0.00% 33 Missing ⚠️
internal/logging/logger.go 37.25% 30 Missing and 2 partials ⚠️
internal/image/lexical_selector.go 0.00% 23 Missing ⚠️
internal/image/semver_selector.go 0.00% 23 Missing ⚠️
internal/api/option/log.go 25.92% 19 Missing and 1 partial ⚠️
internal/controller/promotions/watches.go 50.00% 14 Missing ⚠️
cmd/controlplane/api.go 0.00% 13 Missing ⚠️
cmd/controlplane/controller.go 0.00% 10 Missing ⚠️
internal/kargo/kargo.go 0.00% 9 Missing ⚠️
... and 20 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2073      +/-   ##
==========================================
- Coverage   45.79%   45.69%   -0.10%     
==========================================
  Files         238      237       -1     
  Lines       16278    16401     +123     
==========================================
+ Hits         7455     7495      +40     
- Misses       8455     8540      +85     
+ Partials      368      366       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

krancour added 2 commits May 30, 2024 15:25
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour krancour force-pushed the krancour/logging branch from 8a25f1a to 2110feb Compare May 30, 2024 19:26
@krancour krancour added this pull request to the merge queue May 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 30, 2024
@krancour krancour added this pull request to the merge queue May 31, 2024
Merged via the queue into akuity:main with commit fde59de May 31, 2024
15 checks passed
@krancour krancour deleted the krancour/logging branch May 31, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize on go-logr/logr instead of sirupsen/logrus
2 participants