Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart): provide empty default annotations map for api server ingress #2096

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

krancour
Copy link
Member

@krancour krancour commented Jun 3, 2024

Fixes #2095

@krancour krancour added this to the v0.7.0 milestone Jun 3, 2024
@krancour krancour self-assigned this Jun 3, 2024
@krancour krancour requested a review from a team as a code owner June 3, 2024 20:09
Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for docs-kargo-akuity-io canceled.

Name Link
🔨 Latest commit 9861cdf
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/665e27515572260008567f87

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.61%. Comparing base (afdc0dd) to head (9861cdf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2096   +/-   ##
=======================================
  Coverage   45.61%   45.61%           
=======================================
  Files         238      238           
  Lines       16477    16477           
=======================================
  Hits         7516     7516           
  Misses       8590     8590           
  Partials      371      371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiddeco
Copy link
Contributor

hiddeco commented Jun 3, 2024

Requires a codegen rerun.

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour
Copy link
Member Author

krancour commented Jun 3, 2024

Requires a codegen rerun.

🤦‍♂️ Fixed.

@krancour krancour enabled auto-merge June 3, 2024 20:28
@krancour krancour added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 5e2dac5 Jun 3, 2024
16 checks passed
@krancour krancour deleted the krancour-patch-1 branch June 3, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm template fails when api.ingress.annotations unspecified
2 participants