Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): add cache headers for static assets #2097

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

rbreeze
Copy link
Contributor

@rbreeze rbreeze commented Jun 3, 2024

fixes #2056

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from a team as a code owner June 3, 2024 21:34
Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 9a9610c
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/665e36e2be5d1e0008550373
😎 Deploy Preview https://deploy-preview-2097.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 45.88%. Comparing base (5e2dac5) to head (9a9610c).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/http/http.go 0.00% 5 Missing ⚠️
internal/api/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2097      +/-   ##
==========================================
+ Coverage   45.61%   45.88%   +0.27%     
==========================================
  Files         238      238              
  Lines       16477    16551      +74     
==========================================
+ Hits         7516     7595      +79     
+ Misses       8590     8584       -6     
- Partials      371      372       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@krancour krancour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbreeze rbreeze added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 27f1bcb Jun 3, 2024
23 of 24 checks passed
@rbreeze rbreeze deleted the cache-headers branch June 3, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache headers for static resources
2 participants