-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: beginning of support for multiple pipelines/freight per stage #2154
feat: beginning of support for multiple pipelines/freight per stage #2154
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## multi-pipelines #2154 +/- ##
===================================================
- Coverage 46.31% 46.06% -0.25%
===================================================
Files 242 242
Lines 16763 16655 -108
===================================================
- Hits 7763 7672 -91
+ Misses 8629 8610 -19
- Partials 371 373 +2 ☔ View full report in Codecov by Sentry. |
21e2a58
to
145e303
Compare
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
4029ec0
to
a986fca
Compare
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
a986fca
to
05ca41d
Compare
@hiddeco I think this should be in a re-reviewable state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the progress thus far and the foundation of API changes. Anything else we discover along the way can still be addressed later.
Nice work @krancour 💯
Preliminary work on #1680
Note this isn't headed for main, but for a feature branch @hiddeco will be asynchronously pairing for a bit.
@hiddeco, quick brain dump of what I've gotten done so far:
I basically started with StageSpec changes -- refactoring the subscriptions into FreightSources. Then I went as far as resolving all ripples those changes created.
I have not done anything to StageStatus yet or Promotions, so Stages don't truly have the ability to host multiple pieces of Freight yet.
I have not tested this end-to-end, but I think that except for the UI, it might work.
I leave it entirely up to you if you want to merge this PR and then open your own PR to continue this work, or simply amend this PR.
Lob this whole issue back my way when you tire of it.