Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: beginning of support for multiple pipelines/freight per stage #2154

Merged
merged 15 commits into from
Jun 21, 2024

Conversation

krancour
Copy link
Member

@krancour krancour commented Jun 12, 2024

Preliminary work on #1680

Note this isn't headed for main, but for a feature branch @hiddeco will be asynchronously pairing for a bit.

@hiddeco, quick brain dump of what I've gotten done so far:

I basically started with StageSpec changes -- refactoring the subscriptions into FreightSources. Then I went as far as resolving all ripples those changes created.

I have not done anything to StageStatus yet or Promotions, so Stages don't truly have the ability to host multiple pieces of Freight yet.

I have not tested this end-to-end, but I think that except for the UI, it might work.

I leave it entirely up to you if you want to merge this PR and then open your own PR to continue this work, or simply amend this PR.

Lob this whole issue back my way when you tire of it.

@krancour krancour requested a review from a team as a code owner June 12, 2024 23:10
@krancour krancour added this to the v0.8.0 milestone Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 77.46479% with 48 lines in your changes missing coverage. Please review.

Project coverage is 46.06%. Comparing base (cc9f958) to head (05ca41d).

Files Patch % Lines
internal/cli/cmd/promote/promote.go 0.00% 21 Missing ⚠️
internal/api/promote_downstream_v1alpha1.go 61.90% 7 Missing and 1 partial ⚠️
internal/controller/promotions/promotions.go 0.00% 6 Missing ⚠️
internal/kubeclient/indexer.go 50.00% 5 Missing ⚠️
internal/api/promote_to_stage_v1alpha1.go 40.00% 2 Missing and 1 partial ⚠️
internal/controller/stages/stages.go 96.10% 2 Missing and 1 partial ⚠️
internal/cli/option/flag.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           multi-pipelines    #2154      +/-   ##
===================================================
- Coverage            46.31%   46.06%   -0.25%     
===================================================
  Files                  242      242              
  Lines                16763    16655     -108     
===================================================
- Hits                  7763     7672      -91     
+ Misses                8629     8610      -19     
- Partials               371      373       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour force-pushed the krancour/multi-pipelines branch from 21e2a58 to 145e303 Compare June 18, 2024 22:02
@krancour krancour requested a review from a team as a code owner June 18, 2024 22:02
@krancour krancour changed the base branch from multi-pipelines to main June 18, 2024 22:06
@krancour krancour changed the base branch from main to multi-pipelines June 18, 2024 22:07
krancour and others added 9 commits June 19, 2024 12:57
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@krancour krancour force-pushed the krancour/multi-pipelines branch 3 times, most recently from 4029ec0 to a986fca Compare June 19, 2024 19:23
krancour added 6 commits June 19, 2024 15:53
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour krancour force-pushed the krancour/multi-pipelines branch from a986fca to 05ca41d Compare June 19, 2024 19:54
@krancour
Copy link
Member Author

@hiddeco I think this should be in a re-reviewable state.

@krancour krancour changed the title beginning of support for multiple pipelines/freight per stage feat: beginning of support for multiple pipelines/freight per stage Jun 21, 2024
Copy link
Contributor

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the progress thus far and the foundation of API changes. Anything else we discover along the way can still be addressed later.

Nice work @krancour 💯

@krancour krancour merged commit 80112bb into akuity:multi-pipelines Jun 21, 2024
23 of 26 checks passed
@krancour krancour deleted the krancour/multi-pipelines branch June 21, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants