Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): "approved by" -> "created by" for promotions #2169

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

rbreeze
Copy link
Contributor

@rbreeze rbreeze commented Jun 17, 2024

Fixes #2146

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from a team as a code owner June 17, 2024 18:07
Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 1789679
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66707b4f95e19100088192f0
😎 Deploy Preview https://deploy-preview-2169.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.37%. Comparing base (9fb016e) to head (1789679).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2169   +/-   ##
=======================================
  Coverage   46.37%   46.37%           
=======================================
  Files         242      242           
  Lines       16744    16744           
=======================================
  Hits         7765     7765           
  Misses       8606     8606           
  Partials      373      373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbreeze rbreeze added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit 12edef6 Jun 18, 2024
23 checks passed
@rbreeze rbreeze deleted the promo-create-header branch June 18, 2024 21:40
rbreeze added a commit that referenced this pull request Jun 24, 2024
Signed-off-by: Remington Breeze <remington@breeze.software>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: intent of approved by column in promotions view is unclear (bug?)
2 participants