Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): convenience page for links to CLI binaries #2204

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Conversation

rbreeze
Copy link
Contributor

@rbreeze rbreeze commented Jun 25, 2024

Fixes #2176

When in Dev mode, links to latest. Otherwise, links to embedded version

CleanShot 2024-06-25 at 09 51 54@2x

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from a team as a code owner June 25, 2024 16:53
Copy link

netlify bot commented Jun 25, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 18f5e09
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/667c4d380144d00008279528
😎 Deploy Preview https://deploy-preview-2204.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.30%. Comparing base (31848a4) to head (18f5e09).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2204   +/-   ##
=======================================
  Coverage   46.30%   46.30%           
=======================================
  Files         242      242           
  Lines       16767    16767           
=======================================
  Hits         7764     7764           
  Misses       8632     8632           
  Partials      371      371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ui/src/pages/downloads.tsx Outdated Show resolved Hide resolved
rbreeze added 2 commits June 26, 2024 10:17
Signed-off-by: Remington Breeze <remington@breeze.software>
Copy link
Contributor

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rbreeze 🥇

@rbreeze rbreeze added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit b855fba Jun 26, 2024
23 checks passed
@rbreeze rbreeze deleted the ui-cli-downloads branch June 26, 2024 19:55
@krancour
Copy link
Member

This is a very nice improvement. Thanks @rbreeze !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI download links from UI
3 participants