Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): use correct JSON schema URL in YAML editors #2208

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

rbreeze
Copy link
Contributor

@rbreeze rbreeze commented Jun 26, 2024

Fixes #2116

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from a team as a code owner June 26, 2024 19:06
Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit c7bcadc
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/667c679fcb9fee00081f1aeb
😎 Deploy Preview https://deploy-preview-2208.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Remington Breeze <remington@breeze.software>
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.30%. Comparing base (31848a4) to head (c7bcadc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2208   +/-   ##
=======================================
  Coverage   46.30%   46.30%           
=======================================
  Files         242      242           
  Lines       16767    16767           
=======================================
  Hits         7764     7764           
  Misses       8632     8632           
  Partials      371      371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbreeze rbreeze added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit 93940f9 Jun 26, 2024
23 checks passed
@rbreeze rbreeze deleted the schema-url branch June 26, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI json schema helper links to http://myserver/foo-schema.json
2 participants