feat(controller): irsa support #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2235 +/- ##
==========================================
- Coverage 46.36% 46.35% -0.02%
==========================================
Files 242 242
Lines 16852 16856 +4
==========================================
Hits 7814 7814
- Misses 8658 8662 +4
Partials 380 380 ☔ View full report in Codecov by Sentry. |
krancour
reviewed
Jul 3, 2024
krancour
reviewed
Jul 3, 2024
krancour
reviewed
Jul 3, 2024
krancour
reviewed
Jul 3, 2024
blakepettersson
force-pushed
the
feat/irsa-support
branch
2 times, most recently
from
5bec522 to
268ddb0
Compare
krancour
reviewed
Jul 7, 2024
krancour
reviewed
Jul 7, 2024
krancour
reviewed
Jul 7, 2024
krancour
reviewed
Jul 7, 2024
krancour
added
kind/enhancement
area/controller
priority/normal
priority/high
and removed
priority/normal
labels
blakepettersson
force-pushed
the
feat/irsa-support
branch
from
268ddb0 to
b900ff7
Compare
Building upon akuity#2066, this PR allows IRSA to be used. The reason why we would want to use this is because there are some environments where EKS Pod Identites cannot be used (e.g AWS GovCloud), or e.g for consistency with existing deployments. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Service account annotations are completely separated from other annotations, for now at least. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
blakepettersson
force-pushed
the
feat/irsa-support
branch
from
025ac70 to
776bbe7
Compare
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
blakepettersson
force-pushed
the
feat/irsa-support
branch
from
a542cc1 to
1f325da
Compare
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
krancour
force-pushed
the
feat/irsa-support
branch
from
9e38305 to
426a7f6
Compare
krancour
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building upon #2066, this PR allows IRSA to be used. The reason why we would want to use this is because there are some environments where EKS Pod Identites cannot be used (e.g AWS GovCloud), or e.g for consistency with existing deployments.