Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: if project-scoped ECR auth fails, fallback to default #2285

Merged
merged 11 commits into from
Jul 11, 2024
Merged

feat: if project-scoped ECR auth fails, fallback to default #2285

merged 11 commits into from
Jul 11, 2024

Conversation

rbreeze
Copy link
Contributor

@rbreeze rbreeze commented Jul 11, 2024

No description provided.

@rbreeze
feat: if project-scoped ECR auth fails, fallback to default
9d8dbbd 
Signed-off-by: Remington Breeze <remington@breeze.software>
@netlify Netlify
Copy link

netlify bot commented Jul 11, 2024 •
edited
Loading

✅ Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 1d7268a
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/669053400e96a40008482aab
😎 Deploy Preview https://deploy-preview-2285.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 46.36%. Comparing base (14b6479) to head (1d7268a).
Report is 3 commits behind head on main.

Files Patch % Lines
...nternal/credentials/kubernetes/ecr/pod_identity.go 0.00% 12 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2285      +/-   ##
==========================================
- Coverage   46.38%   46.36%   -0.02%     
==========================================
  Files         242      242              
  Lines       16839    16852      +13     
==========================================
+ Hits         7810     7814       +4     
- Misses       8649     8658       +9     
  Partials      380      380

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rbreeze added 2 commits July 10, 2024 20:23
@rbreeze
lint
0fab671 
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze
go mod
e10f2ee 
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze marked this pull request as ready for review July 11, 2024 03:36
@rbreeze rbreeze requested a review from a team as a code owner July 11, 2024 03:36
@krancour krancour added this to the v0.8.0 milestone Jul 11, 2024
@krancour krancour requested a review from hiddeco July 11, 2024 15:58
rbreeze added 2 commits July 11, 2024 09:38
@rbreeze
fix: use http status code
bceca94 
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze
revert go.mod
e304ca7 
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze
fix: move error msg
f2ee19e 
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from krancour July 11, 2024 16:55
rbreeze and others added 2 commits July 11, 2024 13:10
@rbreeze @krancour
Apply suggestions from code review
5667358 
Co-authored-by: Kent Rancourt <kent.rancourt@gmail.com>
@rbreeze
address code review
f0bc28d 
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from krancour July 11, 2024 20:11
rbreeze added 2 commits July 11, 2024 13:23
@rbreeze
missed a comma *facepalm*
be2c6b7 
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze
lint
e1e89b5 
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit 34d1bfe Jul 11, 2024
15 of 17 checks passed
@rbreeze rbreeze deleted the rbreeze/ecr-fallback branch July 11, 2024 22:10
rbreeze added a commit that referenced this pull request Jul 12, 2024
@rbreeze @krancour
feat: if project-scoped ECR auth fails, fallback to default (#2285)
269ab89 
Signed-off-by: Remington Breeze <remington@breeze.software>
Co-authored-by: Kent Rancourt <kent.rancourt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krancour krancour krancour approved these changes

@hiddeco hiddeco Awaiting requested review from hiddeco

Assignees

@rbreeze rbreeze

Labels
area/controller kind/enhancement priority/high
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rbreeze @krancour @hiddeco