Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kubeclient): tidy indexers and add tests #2300

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented Jul 15, 2024

Backfills some tests and other tidying around indexers which I happened to run into.

Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 35562db
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/6696433343bc62000870a610
😎 Deploy Preview https://deploy-preview-2300.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.63%. Comparing base (9101f2d) to head (35562db).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/kubeclient/indexer.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2300      +/-   ##
==========================================
+ Coverage   47.24%   47.63%   +0.39%     
==========================================
  Files         244      244              
  Lines       17374    17379       +5     
==========================================
+ Hits         8208     8279      +71     
+ Misses       8753     8689      -64     
+ Partials      413      411       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this to the v0.9.0 milestone Jul 15, 2024
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@krancour krancour added this pull request to the merge queue Jul 22, 2024
Merged via the queue into akuity:main with commit 6bd4d9b Jul 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants