Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): fix panic when last promotion has no freight collection #2362

Merged
merged 2 commits into from
Jul 29, 2024
Merged

fix(controller): fix panic when last promotion has no freight collection #2362

merged 2 commits into from
Jul 29, 2024

Conversation

loafoe
Copy link
Contributor

@loafoe loafoe commented Jul 29, 2024

@loafoe loafoe requested a review from a team as a code owner July 29, 2024 13:12
@netlify Netlify
Copy link

netlify bot commented Jul 29, 2024 •
edited
Loading

✅ Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit a74d37f
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66a7f8658af292000865573f
😎 Deploy Preview https://deploy-preview-2362.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hiddeco hiddeco added this to the v0.8.2 milestone Jul 29, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 47.63%. Comparing base (aff97d8) to head (a74d37f).
Report is 5 commits behind head on main.

Files Patch % Lines
internal/controller/promotions/promotions.go 0.00% 10 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2362      +/-   ##
==========================================
- Coverage   47.64%   47.63%   -0.02%     
==========================================
  Files         244      244              
  Lines       17392    17396       +4     
==========================================
  Hits         8287     8287              
- Misses       8694     8698       +4     
  Partials      411      411

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@loafoe
Copy link
Contributor Author

loafoe commented Jul 29, 2024

@hiddeco thanks for reviewing, rebased to make sure DCO passes (signature)

@loafoe
fix(controller): fix panic when last promotion failed
65b90cf 
Signed-off-by: Andy Lo-A-Foe <andy.loafoe@gmail.com>
@hiddeco
chore: tweak conditional logic
a74d37f 
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco changed the title fix(controller): fix panic when last promotion failed fix(controller): fix panic when last promotion has no freight collection Jul 29, 2024
@hiddeco hiddeco added this pull request to the merge queue Jul 29, 2024
Merged via the queue into akuity:main with commit dfcfe02 Jul 29, 2024
18 of 20 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
@loafoe @github-actions
fix(controller): fix panic when last promotion has no freight collect…
ce34b27 
…ion (#2362)

Signed-off-by: Andy Lo-A-Foe <andy.loafoe@gmail.com>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Co-authored-by: Hidde Beydals <hidde@hhh.computer>
(cherry picked from commit dfcfe02)
@akuitybot akuitybot mentioned this pull request Jul 29, 2024
Merged
@akuitybot
Copy link

Successfully created backport PR for release-0.8:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees

@hiddeco hiddeco

@loafoe loafoe

Labels
area/controller backport/release-0.8 kind/bug priority/normal
Projects
None yet
Milestone
v0.8.2
Development

Successfully merging this pull request may close these issues.

panic when promoting freight
3 participants
@loafoe @akuitybot @hiddeco