Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): infinite redirect loop when renewing OIDC token #2374

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

rbreeze
Copy link
Contributor

@rbreeze rbreeze commented Aug 1, 2024

Fixes #2359, #2237

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from a team as a code owner August 1, 2024 23:56
Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit f88107b
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66ac285adc07250008b199b1
😎 Deploy Preview https://deploy-preview-2374.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.63%. Comparing base (1ceaa19) to head (f88107b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2374   +/-   ##
=======================================
  Coverage   47.63%   47.63%           
=======================================
  Files         244      244           
  Lines       17396    17396           
=======================================
  Hits         8287     8287           
  Misses       8698     8698           
  Partials      411      411           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rbreeze added 2 commits August 1, 2024 17:26
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze added this pull request to the merge queue Aug 2, 2024
Merged via the queue into main with commit 2d5ae05 Aug 2, 2024
17 checks passed
@rbreeze rbreeze deleted the rbreeze/login-redirect-loop branch August 2, 2024 15:37
github-actions bot pushed a commit that referenced this pull request Aug 2, 2024
Signed-off-by: Remington Breeze <remington@breeze.software>
(cherry picked from commit 2d5ae05)
@akuitybot
Copy link

Successfully created backport PR for release-0.8:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanly reinstalled cluster & kargo, after performing sso login, kargo is in a loop refreshing page
3 participants