Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): improve logic to determine when syncing an argo cd app is required #2433

Merged
merged 2 commits into from
Aug 15, 2024

improve logic for determining when app sync is required

925b765
Select commit
Loading
Failed to load commit list.
Merged

fix(controller): improve logic to determine when syncing an argo cd app is required #2433

improve logic for determining when app sync is required
925b765
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Aug 15, 2024 in 1s

68.25% of diff hit (target 48.38%)

View this Pull Request on Codecov

68.25% of diff hit (target 48.38%)

Annotations

Check warning on line 182 in internal/controller/promotion/argocd.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotion/argocd.go#L182 

Added line #L182 was not covered by tests

Check warning on line 49 in internal/controller/promotion/composite.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotion/composite.go#L48-L49 

Added lines #L48 - L49 were not covered by tests

Check warning on line 117 in internal/controller/promotion/composite.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotion/composite.go#L117 

Added line #L117 was not covered by tests

Check warning on line 208 in internal/controller/promotion/git.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotion/git.go#L208 

Added line #L208 was not covered by tests

Check warning on line 221 in internal/controller/promotion/git.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotion/git.go#L221 

Added line #L221 was not covered by tests

Check warning on line 243 in internal/controller/promotion/git.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotion/git.go#L243 

Added line #L243 was not covered by tests

Check warning on line 245 in internal/controller/promotion/git.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotion/git.go#L245 

Added line #L245 was not covered by tests

Check warning on line 247 in internal/controller/promotion/git.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotion/git.go#L247 

Added line #L247 was not covered by tests

Check warning on line 120 in internal/controller/promotion/pullrequest.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotion/pullrequest.go#L120 

Added line #L120 was not covered by tests

Check warning on line 123 in internal/controller/promotion/pullrequest.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotion/pullrequest.go#L123 

Added line #L123 was not covered by tests

Check warning on line 127 in internal/controller/promotion/pullrequest.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotion/pullrequest.go#L127 

Added line #L127 was not covered by tests

Check warning on line 132 in internal/controller/promotion/pullrequest.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotion/pullrequest.go#L132 

Added line #L132 was not covered by tests

Check warning on line 148 in internal/controller/promotion/pullrequest.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotion/pullrequest.go#L148 

Added line #L148 was not covered by tests

Check warning on line 154 in internal/controller/promotion/pullrequest.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotion/pullrequest.go#L153-L154 

Added lines #L153 - L154 were not covered by tests

Check warning on line 157 in internal/controller/promotion/pullrequest.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotion/pullrequest.go#L156-L157 

Added lines #L156 - L157 were not covered by tests

Check warning on line 164 in internal/controller/promotion/pullrequest.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotion/pullrequest.go#L164 

Added line #L164 was not covered by tests

Check warning on line 169 in internal/controller/promotion/pullrequest.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotion/pullrequest.go#L169 

Added line #L169 was not covered by tests

Check warning on line 173 in internal/controller/promotion/pullrequest.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotion/pullrequest.go#L172-L173 

Added lines #L172 - L173 were not covered by tests

Check warning on line 175 in internal/controller/promotion/pullrequest.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotion/pullrequest.go#L175 

Added line #L175 was not covered by tests

Check warning on line 180 in internal/controller/promotion/pullrequest.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotion/pullrequest.go#L179-L180 

Added lines #L179 - L180 were not covered by tests

Check warning on line 185 in internal/controller/promotion/pullrequest.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotion/pullrequest.go#L185 

Added line #L185 was not covered by tests

Check warning on line 498 in internal/controller/promotions/promotions.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotions/promotions.go#L492-L498 

Added lines #L492 - L498 were not covered by tests

Check warning on line 500 in internal/controller/promotions/promotions.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotions/promotions.go#L500 

Added line #L500 was not covered by tests

Check warning on line 504 in internal/controller/promotions/promotions.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotions/promotions.go#L504 

Added line #L504 was not covered by tests

Check warning on line 506 in internal/controller/promotions/promotions.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/controller/promotions/promotions.go#L506 

Added line #L506 was not covered by tests
View more details on Codecov