-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support kustomize image newName override #2470
Conversation
Signed-off-by: Jesse Suen <jesse@akuity.io>
✅ Deploy Preview for docs-kargo-akuity-io canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2470 +/- ##
==========================================
- Coverage 48.28% 48.27% -0.01%
==========================================
Files 246 246
Lines 17736 17739 +3
==========================================
+ Hits 8563 8564 +1
- Misses 8748 8749 +1
- Partials 425 426 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jesse Suen <jesse@akuity.io>
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-0.8
git worktree add -d .worktree/backport-2470-to-release-0.8 origin/release-0.8
cd .worktree/backport-2470-to-release-0.8
git switch --create backport-2470-to-release-0.8
git cherry-pick -x 2ab4270d14d2e8a5aa734592984053bc620fc971 |
Is this also able to work with argoCDAppUpdates sourceUpdates? |
@danielloader it was only for git-based changes. |
Some users will use different image repositories for prod vs. preprod. As part of their CI process, they might retag/push images to a production image repository. And so they would take advantage of kustomize's newName feature like so:
The problem is that kargo will only run
kustomize edit set image <image>:<tag>
which blows away thenewName
setting.This change introduces
newName
to the kustomize spec, and when specified, will run:otherwise: