Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): Hide managed fields in UI doesn't work #2513

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix(ui): Hide managed fields in UI doesn't work #2513

merged 1 commit into from
Sep 24, 2024

Conversation

rpelczar
Copy link
Contributor

@rpelczar rpelczar commented Sep 9, 2024 •
edited by krancour
Loading

Fixes #1988

@rpelczar
fix(ui): Hide managed fields in UI doesn't work
9050b07 
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
@rpelczar rpelczar requested a review from a team as a code owner September 9, 2024 14:33
@rpelczar rpelczar linked an issue Sep 9, 2024 that may be closed by this pull request
Hide managed fields in UI doesn't work #1988
Closed
@netlify Netlify
Copy link

netlify bot commented Sep 9, 2024 •
edited
Loading

✅ Deploy Preview for docs-kargo-akuity-io canceled.

Name Link
🔨 Latest commit 9050b07
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66df0759eee7320009f44593

@codecov Codecov
Copy link

codecov bot commented Sep 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.76%. Comparing base (3dd4ec8) to head (9050b07).
Report is 36 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2513   +/-   ##
=======================================
  Coverage   48.76%   48.76%           
=======================================
  Files         250      250           
  Lines       17969    17969           
=======================================
  Hits         8762     8762           
  Misses       8725     8725           
  Partials      482      482

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this to the v0.9.0 milestone Sep 9, 2024
@krancour krancour requested a review from rbreeze September 9, 2024 14:56
@rpelczar rpelczar requested a review from Marvin9 September 18, 2024 22:03
@rpelczar rpelczar added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit fc13b19 Sep 24, 2024
24 checks passed
@rpelczar rpelczar deleted the 1988-hide-managed-fields-in-ui-doesnt-work branch September 24, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marvin9 Marvin9 Marvin9 approved these changes

@krancour krancour krancour approved these changes

@rbreeze rbreeze Awaiting requested review from rbreeze

Assignees

@rpelczar rpelczar

Labels
area/ui kind/bug priority/normal
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

Hide managed fields in UI doesn't work
3 participants
@rpelczar @krancour @Marvin9