Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add git-based promotion directives #2537

Merged
merged 6 commits into from
Sep 17, 2024

Conversation

krancour
Copy link
Member

  • clone
  • overwrite
  • commit
  • push
  • open pr
  • wait for pr

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit e62495c
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66e9b2dbd3e16c0008621338
😎 Deploy Preview https://deploy-preview-2537.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour krancour force-pushed the krancour/git-promo-dirs branch from f93b913 to 1107f6c Compare September 16, 2024 20:19
@krancour krancour marked this pull request as ready for review September 16, 2024 20:19
@krancour krancour requested a review from a team as a code owner September 16, 2024 20:19
@hiddeco hiddeco self-requested a review September 16, 2024 20:51
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco force-pushed the krancour/git-promo-dirs branch from 5a406c0 to 595c380 Compare September 17, 2024 12:13
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 48.01223% with 340 lines in your changes missing coverage. Please review.

Project coverage is 49.61%. Comparing base (a03e949) to head (e62495c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/directives/git_open_pr_directive.go 47.59% 75 Missing and 23 partials ⚠️
internal/directives/git_clone_directive.go 35.76% 72 Missing and 16 partials ⚠️
internal/directives/git_wait_for_pr_directive.go 49.46% 41 Missing and 6 partials ⚠️
internal/directives/git_commit_directive.go 58.02% 26 Missing and 8 partials ⚠️
internal/directives/git_overwrite_directive.go 42.37% 29 Missing and 5 partials ⚠️
internal/directives/git_push_directive.go 50.00% 25 Missing and 7 partials ⚠️
internal/controller/freight/finder.go 50.00% 4 Missing ⚠️
internal/directives/copy_directive.go 0.00% 2 Missing ⚠️
internal/gitprovider/github/github.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2537      +/-   ##
==========================================
- Coverage   49.74%   49.61%   -0.13%     
==========================================
  Files         272      275       +3     
  Lines       19078    19684     +606     
==========================================
+ Hits         9490     9767     +277     
- Misses       9044     9312     +268     
- Partials      544      605      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
return Result{Status: StatusSuccess}, nil
}

func buildCommitMessage(sharedState State, cfg GitCommitConfig) (string, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably make this a method to ensure we do not get it mixed up with the generateCommitMessage methods of the directives which produce Git commit messages as part of their output.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in e62495c

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour krancour enabled auto-merge September 17, 2024 16:49
@krancour krancour added this pull request to the merge queue Sep 17, 2024
Merged via the queue into akuity:main with commit 5c88c84 Sep 17, 2024
15 of 17 checks passed
@krancour krancour deleted the krancour/git-promo-dirs branch September 17, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants