-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add git-based promotion directives #2537
Conversation
krancour
commented
Sep 16, 2024
- clone
- overwrite
- commit
- push
- open pr
- wait for pr
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
eb70397
to
f93b913
Compare
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
f93b913
to
1107f6c
Compare
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
5a406c0
to
595c380
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2537 +/- ##
==========================================
- Coverage 49.74% 49.61% -0.13%
==========================================
Files 272 275 +3
Lines 19078 19684 +606
==========================================
+ Hits 9490 9767 +277
- Misses 9044 9312 +268
- Partials 544 605 +61 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
return Result{Status: StatusSuccess}, nil | ||
} | ||
|
||
func buildCommitMessage(sharedState State, cfg GitCommitConfig) (string, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably make this a method to ensure we do not get it mixed up with the generateCommitMessage
methods of the directives which produce Git commit messages as part of their output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in e62495c