-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api/controller): Promotion directive steps #2539
Conversation
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ee539bf
to
fb1dff1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2539 +/- ##
==========================================
- Coverage 49.60% 49.54% -0.07%
==========================================
Files 275 276 +1
Lines 19690 19761 +71
==========================================
+ Hits 9767 9790 +23
- Misses 9318 9363 +45
- Partials 605 608 +3 ☔ View full report in Codecov by Sentry. |
aa359a2
to
b534e5d
Compare
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
b534e5d
to
e427378
Compare
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
907bdd5
to
99bdb1f
Compare
99bdb1f
to
abf22ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to PromotionContext
This introduces a
PromotionTemplate
withinStage
resources, allowing someone to define a sequence of steps (directives) that should be run to promote Freight to a Stage using a Promotion.When this field is defined for a Stage, any previous "Promotion mechanisms" are ignored for newly created Promotions.
Note: While this pull request makes the feature work from end to end, it still has quite some rough edges, including (nonfunctioning) work directory persistence, result and queue behavior, Stage health checks, etc.