feat(ui): display promotion steps and YAML #2549
Conversation
rbreeze
commented
Sep 19, 2024
•
rbreeze
commented
Signed-off-by: Remington Breeze <remington@breeze.software>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -0,0 +1,152 @@ | |||
| export const testDirectives = [ | |||
There was a problem hiding this comment.
Examples to test feature while waiting for finalized promotion directives
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2549 +/- ##
==========================================
- Coverage 51.04% 51.03% -0.02%
==========================================
Files 282 282
Lines 21056 21099 +43
==========================================
+ Hits 10748 10767 +19
- Misses 9635 9652 +17
- Partials 673 680 +7 ☔ View full report in Codecov by Sentry. |
|
@krancour would you please add more context in this task? or we can discuss offline |
We had a three part plan for cutting over to step-based (directive-based) promotions, then containerizing the built-in steps, then finally opening things up to third-party step runners. I think the exact installation/registration process is something that might currently be absent from that plan. Let's connect about this offline. |
> readonly view in promotions modal > create stage with promotion directive steps Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
| SUCCESS | ||
| } | ||
|
|
||
| export const getPromotionDirectiveStepStatus = ( |
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
| // TODO: controller should point 'currentStep' to exact failed step | ||
| // at the moment, it is defaulted to 0 |
There was a problem hiding this comment.
Actually, I could only find this being set to zero if the steps couldn't even get started or after success. I updated it so it's not set back to zero on success.
I cannot seem to find where a failed step is getting this set back to zero.
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
|
@Marvin9 this looks pretty good. The one bug I am observing is that it seems when the current step is pending, previous steps won't show up as successful:
As soon as the last step turns green, they all do. 😄 I think what we should do is assume success for all steps prior to the current one. |
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
|
I think there is still a small issue here. It seems that on failure, all previous steps are being displayed as failed. Here's a screenshot:
Fundamentally, I believe the UI can assume that if we're on step n > 0, then all steps < n have succeeded. |
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Signed-off-by: Remington Breeze <remington@breeze.software> Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com> Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com> Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com> Co-authored-by: Kent Rancourt <kent.rancourt@gmail.com> (cherry picked from commit 34e599d)
|
Successfully created backport PR for |
Signed-off-by: Remington Breeze <remington@breeze.software> Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com> Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com> Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com> Co-authored-by: Kent Rancourt <kent.rancourt@gmail.com>
