feat(controller): use directives engine for Stage health checks #2580
Conversation
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2580 +/- ##
==========================================
- Coverage 51.09% 51.03% -0.07%
==========================================
Files 281 281
Lines 20713 20757 +44
==========================================
+ Hits 10583 10593 +10
- Misses 9476 9509 +33
- Partials 654 655 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
stage-engine-health-checks
branch
from
9dbb4a3 to
43fa0c5
Compare
| // FinishedAt is the time when the promotion was completed. | ||
| FinishedAt *metav1.Time `json:"finishedAt,omitempty" protobuf:"bytes,6,opt,name=finishedAt"` | ||
| } | ||
|
|
||
| // HealthCheckStep describes a health check directive which can be executed by | ||
| // a Stage to verify the health of a Promotion result. | ||
| type HealthCheckStep struct { |
There was a problem hiding this comment.
I think we could probably make the engine use this type directly instead of directive.HealthCheckStep. The same can probably be said for promotion steps.
I can handle that after this PR is merged since I am still actively working on the directives package and want to avoid creating merge conflicts over there.
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
| directivesEngine := directives.NewSimpleEngine(credentialsDB, kargoMgr.GetClient(), argoCDClient) | ||
| promoMechanisms := promotion.NewMechanisms(kargoMgr.GetClient(), argoCDClient, credentialsDB) |
There was a problem hiding this comment.
I actually love seeing the two of these side-by-side here and knowing half of it goes away soon. 😄
No description provided.