Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updating freight aliases #2606

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Conversation

fykaa
Copy link
Contributor

@fykaa fykaa commented Sep 30, 2024

Addressed an inconsistency in the Kargo documentation related to updating aliases for Freight resources.

Before

image

After

image

Signed-off-by: Faeka Ansari <faeka6@gmail.com>
@fykaa fykaa self-assigned this Sep 30, 2024
@fykaa fykaa requested review from a team as code owners September 30, 2024 08:42
Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit fbc1fcc
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66fa73b8b4175800087c814e
😎 Deploy Preview https://deploy-preview-2606.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.01%. Comparing base (b4cf8ca) to head (1249b8b).
Report is 131 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2606      +/-   ##
==========================================
- Coverage   51.09%   50.01%   -1.08%     
==========================================
  Files         282      274       -8     
  Lines       20961    24386    +3425     
==========================================
+ Hits        10709    12197    +1488     
- Misses       9584    11539    +1955     
+ Partials      668      650      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Faeka Ansari <faeka6@gmail.com>
@fykaa fykaa requested a review from krancour October 7, 2024 05:37
@krancour
Copy link
Member

krancour commented Oct 8, 2024

Nice catch. One comment about formatting and then LGMT.

docs/docs/15-concepts.md Outdated Show resolved Hide resolved
@krancour krancour removed this from the v1.0.0 milestone Oct 11, 2024
Signed-off-by: Faeka Ansari <faeka6@gmail.com>
Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 1249b8b
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/6720f55fd3f9fd00089346dc
😎 Deploy Preview https://deploy-preview-2606.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fykaa
Copy link
Contributor Author

fykaa commented Oct 29, 2024

@krancour can we merge this PR

@@ -45,6 +45,8 @@ include one or more:

Freight can therefore be thought of as a sort of meta-artifact. Freight is what
Kargo seeks to progress from one stage to another.
For detailed guidance on working with Freight, refer to
[this guide](https://kargo.akuity.io/how-to-guides/working-with-freight).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting domain names in a link makes it harder to move the site if/when we need to. (And we just recently did, so it's a thing that can/does happen.)

Just link to pages using file paths instead and Docusaurus will work out the rest:

Suggested change
[this guide](https://kargo.akuity.io/how-to-guides/working-with-freight).
[this guide](./30-how-to-guides/15-working-with-freight.md).

Copy link
Member

@krancour krancour Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I'm fine with you adding this here, but doing so may cause people to overlook the section on the Freight CRD that is farther down on this page, so consider following up on this PR very soon to merge any useful parts of that section into the "Working with Freight" page. Eventually, the CRD sections of the concepts doc can then be removed, as well discussed yesterday.

This isn't blocking this PR. Just please do not lose track of this follow-up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have noted in my documentation tracker that the key concepts guide needs to be improved. This will be looked at soon.

Signed-off-by: Faeka Ansari <faeka6@gmail.com>
@fykaa fykaa requested a review from krancour October 29, 2024 15:03
@fykaa fykaa added this pull request to the merge queue Oct 29, 2024
Merged via the queue into akuity:main with commit f8179dc Oct 29, 2024
16 of 17 checks passed
@fykaa fykaa deleted the docs-working-with-freight branch October 29, 2024 21:28
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
Signed-off-by: Faeka Ansari <faeka6@gmail.com>
(cherry picked from commit f8179dc)
@akuitybot
Copy link

Successfully created backport PR for release-1.0:

fykaa added a commit to fykaa/kargo that referenced this pull request Nov 4, 2024
Signed-off-by: Faeka Ansari <faeka6@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants