Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update wait-for-pr step for improved consistency with other built-ins #2609

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

krancour
Copy link
Member

This swaps the prNumberFromOpen field for prNumberFromStep, thereby not implying that the prNumber output this step consumes needs to have come from an git-open-pr step.

This improves consistency with the other built-in promotion steps, which use the same syntax to avoid implying that input needs to have come from a particular kind of step.

All this will be moot once we have some kind of EL built, but for now, this matters.

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour krancour requested a review from a team as a code owner September 30, 2024 14:12
@krancour krancour self-assigned this Sep 30, 2024
@krancour krancour added this to the v0.9.0 milestone Sep 30, 2024
Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit c47e21a
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66fab5408d4663000883c07e
😎 Deploy Preview https://deploy-preview-2609.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour krancour enabled auto-merge September 30, 2024 14:27
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 51.04%. Comparing base (794cfbc) to head (c47e21a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/directives/git_pr_waiter.go 16.66% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2609   +/-   ##
=======================================
  Coverage   51.04%   51.04%           
=======================================
  Files         282      282           
  Lines       21056    21056           
=======================================
  Hits        10748    10748           
  Misses       9635     9635           
  Partials      673      673           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this pull request to the merge queue Sep 30, 2024
Merged via the queue into akuity:main with commit 5135af2 Sep 30, 2024
16 of 17 checks passed
@krancour krancour deleted the krancour/step-consistency branch September 30, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants