feat(controller)!: queue Stages for Application changes using annotation #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
fix-app-event-handler
branch
from
de0d229
to
6cc2282
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2617 +/- ##
==========================================
- Coverage 51.04% 50.98% -0.07%
==========================================
Files 282 282
Lines 21056 21015 -41
==========================================
- Hits 10748 10714 -34
+ Misses 9635 9630 -5
+ Partials 673 671 -2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
krancour
reviewed
Oct 1, 2024
Comment on lines
-11
to
16
| // AnnotationKeyOIDCPrefix is the prefix of an annotation key that can be set on a | ||
| // ServiceAccount to associate it with any user authenticated via OIDC and having | ||
| // the claim indicated by the full annotation key with any of the values indicated by | ||
| // the annotation. The value of the annotation may be either a scalar string value or a | ||
| // comma-separated list. | ||
| // AnnotationKeyOIDCClaimNamePrefix is the prefix of an annotation key that | ||
| // can be set on a ServiceAccount to associate it with any user authenticated | ||
| // via OIDC and having the claim indicated by the full annotation key with | ||
| // any of the values indicated by the annotation. The value of the annotation | ||
| // may be either a scalar string value or a comma-separated list. | ||
| AnnotationKeyOIDCClaimNamePrefix = "rbac.kargo.akuity.io/claim." |
|
Successfully created backport PR for |
Dickyvio44
approved these changes
Oct 1, 2024
Dickyvio44
approved these changes
Oct 1, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2593
This addresses the above issue by using the
kargo.akuity.io/authorized-stageannotation to determine which Stage should be queued for reconciliation when a state transition of the Application occurs.The support for glob expressions in the annotation had to be removed to facilitate this as we require an absolute reference. However, given what people were trying to do with this (see #2540), not allowing this is presumably better to protect people from making this mistake.
I tested this against all the examples in https://github.com/krancour/kargo-examples/tree/for-v0.9.0 (in bulk), and they all eventually reached a healthy state without requiring manual interference.