Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): promotion directives wizard on stage creation step #2623

Merged
merged 28 commits into from
Oct 11, 2024
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
90cf117
feat(ui): display promotion steps and YAML
rbreeze Sep 19, 2024
513671d
Merge remote-tracking branch 'origin' into rbreeze/promo-directives-d…
Marvin9 Sep 30, 2024
8d082dd
feat(ui): promotion directives
Marvin9 Sep 30, 2024
d46e339
fix(ui): crashing modal
Marvin9 Sep 30, 2024
6590335
requested back end fix
krancour Oct 1, 2024
490a3b6
Update internal/directives/simple_engine.go
krancour Oct 1, 2024
6d5ff24
fix(ui): promotion step logic update
Marvin9 Oct 1, 2024
de9b4a4
feat(ui): promotion directives wizard
Marvin9 Oct 1, 2024
9943cce
fix: json schema of directives
Marvin9 Oct 1, 2024
fed525e
Merge branch 'rbreeze/promo-directives-details' into Marvin9/extend-p…
Marvin9 Oct 1, 2024
3b08444
chore(ui): design updates
Marvin9 Oct 1, 2024
b9a334d
chore(ui): imr
Marvin9 Oct 2, 2024
cbd55a4
update
Marvin9 Oct 4, 2024
1c27fe8
Merge remote-tracking branch 'origin' into Marvin9/extend-promotion-s…
Marvin9 Oct 4, 2024
cd549eb
codegen
Marvin9 Oct 4, 2024
768dd1b
chore(ui): updates
Marvin9 Oct 4, 2024
ca6f53c
ux improvements
Marvin9 Oct 4, 2024
9699c22
Merge remote-tracking branch 'origin' into Marvin9/extend-promotion-s…
Marvin9 Oct 4, 2024
9640788
feat(ui): UI change, replace drawer with inline form
Marvin9 Oct 4, 2024
3704b1b
fix(ui): ordering
Marvin9 Oct 4, 2024
fe8abf0
fix(ui): yaml <-> wizard state
Marvin9 Oct 4, 2024
d56b6d2
chore(ui): update design
Marvin9 Oct 4, 2024
5c879a0
Merge remote-tracking branch 'origin' into Marvin9/extend-promotion-s…
Marvin9 Oct 9, 2024
bc0160f
chore(ui): review updates
Marvin9 Oct 10, 2024
2d48e9a
Update ui/src/features/stage/promotion-steps-wizard/runner-form.modul…
Marvin9 Oct 10, 2024
5a7f0d4
chore(ui): updates
Marvin9 Oct 10, 2024
3cd74ef
Merge remote-tracking branch 'origin' into Marvin9/extend-promotion-s…
Marvin9 Oct 10, 2024
ca9e289
chore(ui): run codegen
Marvin9 Oct 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(ui): ordering
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
  • Loading branch information
Marvin9 committed Oct 4, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 3704b1b592fd7e2ccb674e17adb720c16069e841
Original file line number Diff line number Diff line change
@@ -63,7 +63,7 @@ export const PromotionStepsWizard = (props: PromotionStepsWizardType) => {

return (
<Card
key={`${runner.identifier}-${order}`}
key={`${runner.identifier}-${order}-${runner?.as}`}
className={classNames('cursor-pointer', {
'shadow-sm': isEditingThisRunner,
'border-gray-400': isEditingThisRunner
@@ -83,6 +83,7 @@ export const PromotionStepsWizard = (props: PromotionStepsWizardType) => {
newOrder[order] = selectedRunners[order - 1];
newOrder[order - 1] = runner;
setSelectedRunners(newOrder);
setEditingRunner({ ...runner, order: order - 1 });
}}
/>
)}
@@ -96,6 +97,7 @@ export const PromotionStepsWizard = (props: PromotionStepsWizardType) => {
newOrder[order] = selectedRunners[order + 1];
newOrder[order + 1] = runner;
setSelectedRunners(newOrder);
setEditingRunner({ ...runner, order: order + 1 });
}}
/>
)}
@@ -137,7 +139,7 @@ export const PromotionStepsWizard = (props: PromotionStepsWizardType) => {
title={
<>
<FontAwesomeIcon icon={faCog} className='mr-2' />
{editingRunner.order} - {liveEditingRunner.identifier}{' '}
{editingRunner.order + 1} - {liveEditingRunner.identifier}{' '}
{liveEditingRunner?.as && (
<Tag color='blue' className='ml-4'>
{liveEditingRunner.as}