Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): fix message that was getting lost beteen step and reconciler #2637

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix(controller): fix message that was getting lost beteen step and reconciler #2637

merged 1 commit into from
Oct 2, 2024

Conversation

krancour
Copy link
Member

@krancour krancour commented Oct 2, 2024

Messages in promotion step results were getting lost because the engine wasn't using them to populate the message field for the overall promotion step result.

@krancour
fix message that was getting lost beteen step and reconciler
97fd35a 
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour krancour added this to the v0.9.0 milestone Oct 2, 2024
@krancour krancour self-assigned this Oct 2, 2024
@krancour krancour requested a review from a team as a code owner October 2, 2024 21:02
@netlify Netlify
Copy link

netlify bot commented Oct 2, 2024 •
edited
Loading

✅ Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 97fd35a
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66fdb4db8ca3900008a07ad0
😎 Deploy Preview https://deploy-preview-2637.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@krancour krancour enabled auto-merge October 2, 2024 21:03
@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.02%. Comparing base (0c5a728) to head (97fd35a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/directives/simple_engine.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2637      +/-   ##
==========================================
- Coverage   51.03%   51.02%   -0.01%     
==========================================
  Files         282      282              
  Lines       21120    21121       +1     
==========================================
  Hits        10778    10778              
- Misses       9657     9658       +1     
  Partials      685      685

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this pull request to the merge queue Oct 2, 2024
Merged via the queue into akuity:main with commit aac9ea0 Oct 2, 2024
25 of 26 checks passed
@krancour krancour deleted the krancour/fix-lost-message branch October 2, 2024 21:23
github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
@krancour @github-actions
fix(controller): fix message that was getting lost beteen step and re…
6cfb77d 
…conciler (#2637)

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
(cherry picked from commit aac9ea0)
@akuitybot akuitybot mentioned this pull request Oct 2, 2024
Merged
@akuitybot
Copy link

Successfully created backport PR for release-0.9:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marvin9 Marvin9 Marvin9 approved these changes

Assignees

@krancour krancour

Labels
area/controller backport/release-0.9 kind/bug priority/high
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@krancour @akuitybot @Marvin9