fix: use mkdirall when creating ~/.ssh dir to allow for the case where it already exists #2708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem that only occurs when using ssh to interact with a remote repo.
We re-setup auth mechanisms every time we load an already-cloned repo from disk because the possibility always exists that for a long-running promotion step, credentials for the repo have been updated between two executions of that step. I am confident this is the right thing to do, however, when using SSH, there is an
os.Mkdir()
call that can fail because the directory it attempts to create would have been created by the previous execution of the auth setup logic.This PR solves that problem by using
os.MkdirAll()
instead, as that will not error if the directory already exists.Part of #2492