chore: don't suppress echoing commands of hack-build target #2710
Conversation
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2710 +/- ##
==========================================
- Coverage 49.11% 49.09% -0.03%
==========================================
Files 270 270
Lines 19328 19342 +14
==========================================
+ Hits 9492 9495 +3
- Misses 9217 9226 +9
- Partials 619 621 +2 ☔ View full report in Codecov by Sentry. |
Makefile
Outdated
| $(CONTAINER_RUNTIME) run -d -p 5000:$(LOCAL_REG_PORT) --name tmp-registry registry:2; \ | ||
| trap '$(CONTAINER_RUNTIME) rm -f tmp-registry' EXIT; \ | ||
| docker push $(BASE_IMAGE):latest-amd64; \ | ||
| docker push $(BASE_IMAGE):latest-arm64; \ | ||
| $(CONTAINER_RUNTIME) buildx build \ | ||
| $(DOCKER_BUILD_OPTS) \ | ||
| --network host \ | ||
| --platform linux/amd64 \ |
There was a problem hiding this comment.
This does not appear to match the example usage comment from above.
There was a problem hiding this comment.
This is accidental. Thank you for catching. Coincidentally, I'd put that there temporarily because setting IMAGE_PLATFORMS doesn't seem to have the intended effect. I had intended to troubleshoot that later and open a separate PR.
There was a problem hiding this comment.
I think the origin of the issue is that we stopped taking IMAGE_PLATFORMS into account at some point.
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
In #2697 I had not meant to suppress the commands in the
hack-buildtarget from being echoed. Seeing the commands is helpful for troubleshooting purposes.