fix: relax clone step config validation to allow ssh urls #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hiddeco
approved these changes
Oct 10, 2024
|
I need to fix a test. |
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2711 +/- ##
==========================================
- Coverage 49.11% 49.09% -0.03%
==========================================
Files 270 270
Lines 19328 19342 +14
==========================================
+ Hits 9492 9495 +3
- Misses 9217 9226 +9
- Partials 619 621 +2 ☔ View full report in Codecov by Sentry. |
Marvin9
pushed a commit
that referenced
this pull request
Oct 11, 2024
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was too restrictive to permit ssh URLs.
Note that the schemas for
git-open-prandgit-wait-for-prdo not require the same change because you cannot interact with a Git provider's API over ssh, so the http/s URL is always used for those steps.Part of #2492