Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove version info from docs and scripts #2713

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

krancour
Copy link
Member

Follow-up to #2706

This updates the lives scripts (the productions docs site references scripts from main) to omit version information from installs -- which will effectively install the latest release. This should have been done at the time of the release and was overlooked. #2706 did the trick (thank you @christianh814), but omitting version info entirely from the install commands means we don't need to update this every time there is a minor release.

This PR also make similar updates the edge docs at main.kargo.akuity.io (old) and main.docs.kargo.io (new; but not working yet).

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit e181c2a
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/67073cc1ed3c6e0008b6c8ab
😎 Deploy Preview https://deploy-preview-2713.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit e181c2a
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/67073cc19c41b400084d001a
😎 Deploy Preview https://deploy-preview-2713--docs-kargo-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.11%. Comparing base (096d2b1) to head (e181c2a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2713   +/-   ##
=======================================
  Coverage   49.11%   49.11%           
=======================================
  Files         270      270           
  Lines       19328    19328           
=======================================
  Hits         9492     9492           
  Misses       9217     9217           
  Partials      619      619           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this pull request to the merge queue Oct 10, 2024
Merged via the queue into akuity:main with commit bc43ce6 Oct 10, 2024
28 checks passed
@krancour krancour deleted the krancour/doc-script-cleanup branch October 10, 2024 12:42
Marvin9 pushed a commit that referenced this pull request Oct 11, 2024
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants