refactor(chart): resume using official kargo image for cabundle init containers #2732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
krancour
changed the title
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2732 +/- ##
=======================================
Coverage 49.16% 49.16%
=======================================
Files 270 270
Lines 19357 19363 +6
=======================================
+ Hits 9516 9519 +3
- Misses 9219 9221 +2
- Partials 622 623 +1 ☔ View full report in Codecov by Sentry. |
hiddeco
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2697 we went distroless and shell-less. At that time, lack of a shell forced us to stop using the official Kargo image for the init container that preps any custom CA bundles. We fell back on using
alpine/curl:latestIn #2709, for unrelated reasons, we added a minimal shell env (busybox).
As we've discussed offline, now that we've done this, we can resume using the official kargo image as the init container and it shrinks Kargo's overall footprint a tad by eliminating a dependency on an image we're not in control of.
cc @gdsoumya