Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): sort images by semver #2780

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Conversation

Marvin9
Copy link
Contributor

@Marvin9 Marvin9 commented Oct 18, 2024

fixes sorting - #2767

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
@Marvin9 Marvin9 requested a review from a team as a code owner October 18, 2024 17:35
@Marvin9 Marvin9 self-assigned this Oct 18, 2024
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit b2dbeff
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/6712a097b970150008072b5d
😎 Deploy Preview https://deploy-preview-2780--docs-kargo-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.05%. Comparing base (4459ce2) to head (b2dbeff).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2780   +/-   ##
=======================================
  Coverage   49.05%   49.05%           
=======================================
  Files         272      272           
  Lines       24196    24197    +1     
=======================================
+ Hits        11870    11871    +1     
  Misses      11690    11690           
  Partials      636      636           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
@Marvin9 Marvin9 requested a review from krancour October 18, 2024 17:40
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
@Marvin9 Marvin9 requested a review from rpelczar October 18, 2024 17:54
Copy link
Contributor

@rpelczar rpelczar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Marvin9 Marvin9 added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 106a408 Oct 18, 2024
17 checks passed
@Marvin9 Marvin9 deleted the Marvin9/feat-semver-compare-images branch October 18, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants