Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix for deciding to wait for verification or skip to next promo #2783

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

krancour
Copy link
Member

It's a bit of a flaw that we're potentially making some decisions here based on health assessed in a previous reconciliation loop. That being said, we can sort of get away with it because we only decide to not wait for verification when we see "unhealthy," which means we are already in dire circumstances and the next promo may be what fixes it... turns out, we should handle nil health the same way.

Strategically, @hiddeco and I are in agreement that we need bigger modifications to the stage reconciliation loop to assess health at a different point in that loop so it's ideally never nil and also more up-to-date.

I'll be opening a separate issue for this refactoring.

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour krancour added this to the v1.0.0 milestone Oct 19, 2024
@krancour krancour requested a review from hiddeco October 19, 2024 00:56
@krancour krancour self-assigned this Oct 19, 2024
@krancour krancour requested a review from a team as a code owner October 19, 2024 00:56
Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit e2781af
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/671303a4f024250009a492d6
😎 Deploy Preview https://deploy-preview-2783--docs-kargo-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.83%. Comparing base (bfb2d64) to head (e2781af).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/controller/stages/stages.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2783   +/-   ##
=======================================
  Coverage   48.83%   48.83%           
=======================================
  Files         270      270           
  Lines       23932    23932           
=======================================
  Hits        11687    11687           
  Misses      11616    11616           
  Partials      629      629           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour enabled auto-merge October 19, 2024 01:05
@krancour krancour added this pull request to the merge queue Oct 19, 2024
Merged via the queue into akuity:main with commit cf12780 Oct 19, 2024
23 of 24 checks passed
@krancour krancour deleted the krancour/verification-fix branch October 19, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants