fix: fix for deciding to wait for verification or skip to next promo #2783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit of a flaw that we're potentially making some decisions here based on health assessed in a previous reconciliation loop. That being said, we can sort of get away with it because we only decide to not wait for verification when we see "unhealthy," which means we are already in dire circumstances and the next promo may be what fixes it... turns out, we should handle nil health the same way.
Strategically, @hiddeco and I are in agreement that we need bigger modifications to the stage reconciliation loop to assess health at a different point in that loop so it's ideally never nil and also more up-to-date.
I'll be opening a separate issue for this refactoring.