Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart): add patchs on promos to kargo-admin clusterrole #2807

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

krancour
Copy link
Member

Fixes #2790

Follows up on #2749 and #2760

cc @shmargum. Thanks for reporting.

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 5aa5552
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/67170ba167e5bf000862bcf6
😎 Deploy Preview https://deploy-preview-2807--docs-kargo-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.79%. Comparing base (a2926d1) to head (5aa5552).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2807   +/-   ##
=======================================
  Coverage   48.79%   48.79%           
=======================================
  Files         270      270           
  Lines       23962    23962           
=======================================
  Hits        11692    11692           
  Misses      11639    11639           
  Partials      631      631           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this pull request to the merge queue Oct 22, 2024
Merged via the queue into akuity:main with commit c0caeb6 Oct 22, 2024
26 checks passed
@krancour krancour deleted the krancour/allow-admin-patch-promotion branch October 22, 2024 10:46
github-actions bot pushed a commit that referenced this pull request Oct 22, 2024
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
(cherry picked from commit c0caeb6)
@akuitybot
Copy link

Successfully created backport PR for release-1.0:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin Role cannot abort promotions
3 participants