fix: sharded Warehouse cross-controller access #2819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow Warehouse resources to be accessible by all controllers in a sharded setup, while still being handled by one controller at a time. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
gdsoumya
approved these changes
Oct 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2819 +/- ##
==========================================
- Coverage 48.84% 48.82% -0.02%
==========================================
Files 270 270
Lines 23934 23941 +7
==========================================
Hits 11690 11690
- Misses 11613 11620 +7
Partials 631 631 ☔ View full report in Codecov by Sentry. |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Hidde Beydals <hidde@hhh.computer> (cherry picked from commit 7490ff2)
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Warehouse resources to be accessible by all controllers in a sharded setup, while still being handled by one controller at a time.
Note: This assumes that only other controller instances desire to access Warehouses. If there is another case of sharding where other kinds are expected to be handled by shard X but able to be "seen" by shard Z, this will still not work.